Skip to content

bump to Rust 2024 edition #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2025
Merged

bump to Rust 2024 edition #46

merged 2 commits into from
Mar 27, 2025

Conversation

connortsui20
Copy link
Member

@connortsui20 connortsui20 commented Mar 27, 2025 •
edited
Loading

Problem

Bumps the rust edition to 2024.

Summary of changes

I just ran cargo fix --edition for 2024, and there were very few changes needed.

Rationale

This isn't just about being stale, this would make writing the rule engine SO MUCH easier. Notably async closures would help quite a lot with all of the continuations in the rule engine (the verbosity right now makes it hard to grok). There is basically no hope for someone trying to contribute to the rule engine who doesn't understand how futures in Rust works...

Also once this gets stabilized things become so much nicer: rust-lang/rust#138424 (it would mean we don't have to have the UnitFuture type alias and Box::pin all of our continuations with the dyn Trait coercions).

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.3%. Comparing base (0f6379f) to head (93fa76b).

Additional details and impacted files
Files with missing lines Coverage Δ
optd-core/src/bridge/from_cir.rs 0.0% <ø> (ø)
optd-core/src/bridge/into_cir.rs 0.0% <ø> (ø)
optd-core/src/engine/eval/binary.rs 80.7% <ø> (ø)
optd-core/src/engine/eval/core.rs 100.0% <ø> (ø)
optd-core/src/engine/eval/expr.rs 95.1% <ø> (ø)
optd-core/src/engine/eval/match.rs 99.0% <100.0%> (+<0.1%) ⬆️
optd-core/src/engine/eval/mod.rs 96.6% <ø> (ø)
optd-core/src/engine/eval/operator.rs 100.0% <ø> (ø)
optd-core/src/engine/eval/unary.rs 80.8% <ø> (ø)
optd-core/src/engine/mod.rs 6.4% <ø> (ø)
... and 18 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlSchlo AlSchlo merged commit 472aca6 into main Mar 27, 2025
11 checks passed
@AlSchlo AlSchlo deleted the rust-2024 branch March 27, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlSchlo AlSchlo AlSchlo approved these changes

@yliang412 yliang412 Awaiting requested review from yliang412

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@connortsui20 @codecov-commenter @AlSchlo